Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAGE-545] Modal - add gap property #1495

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[SAGE-545] Modal - add gap property #1495

merged 1 commit into from
Jul 7, 2022

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Jul 1, 2022 •
edited
Loading

Description

Screenshots

Before After
Screen_Shot_2022-07-01_at_10_05_43_AM Screen_Shot_2022-07-01_at_10_05_24_AM

Testing in sage-lib

Visit the Modal views and verify that the gap property is functioning correctly:

Testing in kajabi-products

  1. (LOW) Adds new property to the Modal component.

Related

Closes SAGE-545

@QuintonJason QuintonJason self-assigned this Jul 1, 2022
@QuintonJason QuintonJason added the improvement Improve on existing work label Jul 1, 2022
@QuintonJason QuintonJason marked this pull request as ready for review July 1, 2022 17:49
@QuintonJason QuintonJason requested review from a team July 1, 2022 17:49
philschanely
philschanely approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@philschanely philschanely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

pixelflips
pixelflips approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 (screenshots are confusing though)

teenwolfblitzer
teenwolfblitzer approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@QuintonJason QuintonJason merged commit b0abee5 into develop Jul 7, 2022
@QuintonJason QuintonJason mentioned this pull request Jul 7, 2022
Merged
1 task
@QuintonJason QuintonJason deleted the SAGE-545_qj-modalcontent-gap branch December 5, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschanely philschanely philschanely approved these changes

@pixelflips pixelflips pixelflips approved these changes

@teenwolfblitzer teenwolfblitzer teenwolfblitzer approved these changes

Assignees

@QuintonJason QuintonJason

Labels
improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuintonJason @teenwolfblitzer @pixelflips @philschanely