-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAGE-517] Banner: Add storybook examples and update logic to pass active state through components #1554
Conversation
Question for reviewers: How would you rate this kind of change in terms of KP risk? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...job well done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 LGTM! The title/description of the PR was confusing to me, since it looks like the original ticket referenced the incorrect component "Alert" rather than "Banner". Perhaps the Jira ticket should be updated rather than the PR to make that clear?
bannerContext: 'sage-demo' | ||
}; | ||
|
||
export const SecondaryInlineBanner = Template.bind({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
EDIT: whoops, just realized I was still thinking |
); | ||
|
||
Banner.TYPES = BANNER_TYPES; | ||
|
||
// Defining all default props and prop types explicitly to populate story table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates. I would also tag this documentation
since you added more examples
Description
Update banner logic slightly and add more stories to bring storybook into parity with rails examples.
Note: Original issue noted in ticket is no longer relevant
Screenshots
Testing in
sage-lib
Open react app, check banner stories.
http://localhost:4100/?path=/docs/sage-banner--default
Testing in
kajabi-products
Related
https://kajabi.atlassian.net/browse/SAGE-517