[SAGE-518] Modal - remove ability to scroll background when modal is open #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing the |
ju-Skinner
reviewed
Aug 16, 2022
| @@ -36,6 +36,11 @@ export const Modal = ({ | |||
| } | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
| document.body.className = 'sage-page--has-open-modal'; | |||
| return () => { document.body.className = ''; }; | |||
There was a problem hiding this comment.
Good job...resetting the class when the Modal unmounts :chefkiss:
I'll look into this |
QuintonJason
force-pushed
the
SAGE-518/qj-modal-scroll-background-when-open
branch
from
01085ec to
02142b3
Compare
pixelflips
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
LGTM! Working as expected. Nice work! 🔥
I also enabled the bridge and then ran the spec that was causing the headache with the last iteration and it's passing as well.
May want to add the pipelines blueprint pages as an area that QE should check as well just in case.
goodwinchris
approved these changes
Aug 18, 2022
philschanely
approved these changes
Aug 18, 2022
| @@ -23,6 +23,6 @@ $-banner-height-offset: map-get($sage-banner-heights, default); | |||
| margin-bottom: sage-spacing(); | |||
| } | |||
|
|
|||
| .sage-page__has-open-modal { | |||
| .sage-page--has-open-modal { | |||
QuintonJason
force-pushed
the
SAGE-518/qj-modal-scroll-background-when-open
branch
from
60c887f to
d1be6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing in
sage-libVisit the Modal page and verify that
.sage-page--has-open-modalis present in the<body>when a modal is open to prevent background scrolling.Testing in
kajabi-products<body>when modal a modal is open.Related
Closes SAGE-518