[SAGE-780] SageGrid column class fix
#1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teenwolfblitzer
commented
Aug 23, 2022
| elsif !col.breakpoint.present? && !col.size.present? && grid_col_legacy(col) | ||
| # or if a legacy individual breakpoint is provided | ||
| grid_col_breakpoint_individual(col, column_classes) | ||
| else |
There was a problem hiding this comment.
Providing a breakpoint value without a size constraint will output the plain sage-col since a size is required for these columns to be useful.
teenwolfblitzer
force-pushed
the
SAGE-780_grid_helper_breakpoint_patch
branch
from
923a5f9
to
18f19c6
Compare
QuintonJason
approved these changes
Aug 26, 2022
philschanely
approved these changes
Aug 26, 2022
pixelflips
approved these changes
Aug 26, 2022
That's a great point, my primary goal was to decouple the conditionals from the markup, but creating a new helper is probably unnecessary. Since this was intended as a somewhat temporary patch until the 12-col grid situation is fleshed out, I'm inclined to wait to fold it in until we have a chance to refactor the component. |
teenwolfblitzer
force-pushed
the
SAGE-780_grid_helper_breakpoint_patch
branch
from
18f19c6
to
537cc26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SAGE-780
Addresses a bug in the 12-column grid when using Rails
SageGridColcomponent by removing the duplicatesage-colclass when a responsive breakpoint is provided. In certain cases, this caused irregular sizing issues due to conflicting media queries.Most easily noticeable when the
lgbreakpoint is in use. For example, open the "Help & Feedback" modal in the KP sidebar, and note that thesage-col--lg-6columns follow thesage-col-6media query when resized.Screenshots
Testing in
sage-lib.docs-section)sage-col--md-4)Testing in
kajabi-productsSageGridColcomponentRelated