Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-175] Add Google Analytics to Sassdocs #1601

Merged
merged 2 commits into from
Sep 29, 2022
Merged

[DSS-175] Add Google Analytics to Sassdocs #1601

merged 2 commits into from
Sep 29, 2022

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Sep 28, 2022 •
edited
Loading

Description

Adds Google Analytics tracking to the Sage Sassdocs website.
The tracking code is added by using a Sassdocs config file as outlined here & here.

Screenshots

Screen Shot 2022-09-28 at 12 49 34 PM

Testing in sage-lib

  • Install Google Analytics Debugger (extension)
  • Navigate to Sage Sassdocs
  • Open Chrome DevTools to Console
  • Turn on the GA extension
  • Refresh the page and verify ID matches UA-238598709-3

Testing in kajabi-products

  1. (LOW) Adds GA tracking to Sage Sassdocs website. No KP impact is expected.

Related

https://kajabi.atlassian.net/browse/DSS-175

@pixelflips pixelflips added documentation Improvements or additions to documentation improvement Improve on existing work labels Sep 28, 2022
@pixelflips pixelflips self-assigned this Sep 28, 2022
@pixelflips pixelflips marked this pull request as ready for review September 29, 2022 16:34
@pixelflips pixelflips requested review from ju-Skinner and a team September 29, 2022 16:34
ju-Skinner
ju-Skinner approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great work

@pixelflips pixelflips requested a review from a team September 29, 2022 20:11
@pixelflips pixelflips merged commit 41db3de into develop Sep 29, 2022
@pixelflips pixelflips deleted the DSS-175_pl-sassdocs-google-analytics branch September 29, 2022 20:26
@pixelflips pixelflips mentioned this pull request Sep 29, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschanely philschanely philschanely approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

Assignees

@pixelflips pixelflips

Labels
documentation Improvements or additions to documentation improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelflips @ju-Skinner @philschanely