-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSS-183]: Storybook Components Not Displaying Code Examples #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one non-blocking change: the Popover story is gigantic. Can we remove the defined height in that story?
@anechol If we completely remove it, the popover gets cut off when it's opened. I'll find a height that still allows it to display properly. Right now it's 100vh, I'll find a better value. Thanks for pointing that out! |
Description
Code examples for the following components do not display properly in Storybook.
Most are returning
<No Display Name />
instead of markup.Updates included using the
{Story()}
function when using decorators in the component story.Screenshots
Testing in
sage-lib
Navigate to Storybook
Visit each component listed above.
Verify code examples now display on Docs tab.
Testing in
kajabi-products
Related
https://kajabi.atlassian.net/browse/DSS-183