Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fix Tabs story #1644

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

ju-Skinner
Copy link
Collaborator

Jira Ticket

https://kajabi.atlassian.net/browse/DSS-184

Description

Resolves the issue of Storybook "source code" not showing when using Decorators.

Screenshots

Before After
image image

@ju-Skinner ju-Skinner self-assigned this Dec 1, 2022
@ju-Skinner ju-Skinner requested a review from a team December 1, 2022 16:40
Show code was not showing the code when viewing on the Doc Page

Locally you were unable to load docs page, this is fixed now
@ju-Skinner ju-Skinner force-pushed the DSS-184/fix-storybook-tabs branch from d271126 to d0660a5 Compare December 1, 2022 16:43
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 All are displaying as expected and the browser no longer hangs when running locally. Nice work! LGTM!

@pixelflips pixelflips requested a review from a team December 1, 2022 16:47
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@ju-Skinner ju-Skinner merged commit 3756883 into develop Dec 1, 2022
@ju-Skinner ju-Skinner deleted the DSS-184/fix-storybook-tabs branch December 1, 2022 18:36
@ju-Skinner ju-Skinner mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants