Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-241]: Remove white background from input labels #1654

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[DSS-241]: Remove white background from input labels #1654

merged 1 commit into from
Dec 7, 2022

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Dec 7, 2022 •
edited
Loading

Description

When adding form elements in areas that have a background that isn't white, the input labels appear with a white background. This is most likely a leftover background color from the previous (floating label) designs.

  • FormInput
  • FormSelect
  • FormTextarea

Screenshots

Before After
Screen Shot 2022-12-07 at 8 50 01 AM Screen Shot 2022-12-07 at 8 50 51 AM

Testing in sage-lib

  • Navigate to docs site and to the components listed above
  • Verify white background color is no longer applied to input labels.

Testing in kajabi-products

  1. (LOW) Removed white background color from form input labels.
    • Sanity check any pages with Sage form inputs.

Related

https://kajabi.atlassian.net/browse/DSS-241

@pixelflips pixelflips added the bug Something isn't working label Dec 7, 2022
@pixelflips pixelflips self-assigned this Dec 7, 2022
@pixelflips pixelflips marked this pull request as ready for review December 7, 2022 17:34
@pixelflips pixelflips requested a review from a team December 7, 2022 17:35
@ju-Skinner ju-Skinner requested a review from a team December 7, 2022 17:50
@pixelflips pixelflips merged commit cd5a064 into develop Dec 7, 2022
@pixelflips pixelflips deleted the DSS-241_pl-form-labels-background branch December 7, 2022 19:02
@pixelflips pixelflips mentioned this pull request Dec 7, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@goodwinchris goodwinchris goodwinchris approved these changes

Assignees

@pixelflips pixelflips

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelflips @goodwinchris @ju-Skinner