Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-336] Remove sass-rails gem #1729

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[DSS-336] Remove sass-rails gem #1729

merged 1 commit into from
Apr 12, 2023

Conversation

teenwolfblitzer
Copy link
Member

@teenwolfblitzer teenwolfblitzer commented Apr 10, 2023 •
edited
Loading

Description

Removes sass-rails gem. No longer necessary now that sass package is applied in sage-assets.

Testing in sage-lib

Testing in kajabi-products

  1. (LOW) Removes deprecated sass-rails gem from repo. No impact on external sources.

Related

@teenwolfblitzer teenwolfblitzer self-assigned this Apr 10, 2023
@teenwolfblitzer teenwolfblitzer marked this pull request as draft April 10, 2023 22:14
@teenwolfblitzer teenwolfblitzer marked this pull request as ready for review April 11, 2023 16:22
@teenwolfblitzer teenwolfblitzer requested a review from a team April 11, 2023 16:22
pixelflips
pixelflips approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@pixelflips pixelflips requested a review from a team April 11, 2023 21:01
@goodwinchris goodwinchris requested a review from a team April 12, 2023 14:09
@teenwolfblitzer teenwolfblitzer merged commit f979930 into develop Apr 12, 2023
@teenwolfblitzer teenwolfblitzer deleted the DSS-336_deprecate_sassrails_gem branch April 12, 2023 17:54
@teenwolfblitzer teenwolfblitzer mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@goodwinchris goodwinchris goodwinchris approved these changes

Assignees

@teenwolfblitzer teenwolfblitzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teenwolfblitzer @goodwinchris @pixelflips