Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-385] Icons: Update icon font (v.18, 1 new) #1731

Merged
merged 4 commits into from
Apr 14, 2023
Merged

[DSS-385] Icons: Update icon font (v.18, 1 new) #1731

merged 4 commits into from
Apr 14, 2023

Conversation

pixelflips
Copy link
Member

Description

Updates the Sage fonts and adds 1 new icon to the system:

  • pause

Rename prev pause icon

  • pause-circle

Screenshots

Name
pause Screenshot 2023-04-13 at 3 21 38 PM
pause-circle Screenshot 2023-04-13 at 3 21 49 PM

Testing in sage-lib

Docs Site:

  1. Navigate to icons
  2. Verify new icon is added to the system
  3. Verify all icons are rendering as expected
  4. Verify Sage font is served from the /v18 directory from CDN (Network panel in dev tools)

Storybook:

  1. Navigate to icons
  2. Verify new icon is added to the system
  3. Verify all icons are rendering as expected

Testing in kajabi-products

  1. (LOW) Updated icon font w/ 1 new icon (v18). No KP impact is expected.

Related

https://kajabi.atlassian.net/browse/DSS-385

@pixelflips pixelflips self-assigned this Apr 13, 2023
@pixelflips pixelflips marked this pull request as ready for review April 13, 2023 22:43
@pixelflips pixelflips requested a review from a team April 13, 2023 22:43
teenwolfblitzer
teenwolfblitzer approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Since the automated process is still a ways down the road, does design have any other icons they might want to add in?

@teenwolfblitzer teenwolfblitzer requested a review from a team April 13, 2023 23:50
@pixelflips
Copy link
Member Author

pixelflips commented Apr 14, 2023 •
edited
Loading

👍 LGTM! Since the automated process is still a ways down the road, does design have any other icons they might want to add in?

I had Chris ping the design team and we confirmed there were no others needed. Famous last words.

@goodwinchris goodwinchris requested a review from a team April 14, 2023 19:23
QuintonJason
QuintonJason approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@pixelflips pixelflips merged commit 624b3fb into develop Apr 14, 2023
@pixelflips pixelflips deleted the DSS-385_pl-update-sage-icon-font-v18 branch April 14, 2023 19:50
@pixelflips pixelflips mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintonJason QuintonJason QuintonJason approved these changes

@teenwolfblitzer teenwolfblitzer teenwolfblitzer approved these changes

@goodwinchris goodwinchris goodwinchris approved these changes

Assignees

@pixelflips pixelflips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pixelflips @goodwinchris @teenwolfblitzer @QuintonJason