[DSS-210] Bug: Icon role not present #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
approved these changes
May 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects an accessibility violation in the Icon component by adding
role="img"when anaria-labelis applied. This is only necessary because we're using an icon font, where the unicode character does not provide a useful label.Note: see the potential drawbacks to this patch when loading is interrupted.
Screenshots
Testing in
sage-libaria-labelonly)role="img"has been applied to the componentTesting in
kajabi-productsroleattribute on uses of icons with labels. Accessibility-only, no visual or functional impact inkajabi-products.Related