fix(react-button): suppressDefaultClass warning #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warrning occurs when the property was being set on a HTML button The conditional fixes that by checking if it's a Link component fix: DSS-374
|
I know we closed this issue, but I forgot I already had a branch with the fix. If we still feel like we want to leave it to rest easy, then we can. cc: @monicawheeler |
teenwolfblitzer
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning occurs when the property was being set on a HTML button
The conditional fixes that by checking if it's a Link component
fix: DSS-374
How to test