fix(alert): grid template areas #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
changed the title
pixelflips
requested changes
May 15, 2023
ju-Skinner
force-pushed
the
fix/alert-grid-template-areas
branch
from
c2ddd19
to
c5e72d6
Compare
this introduced a default story with minimum data this also adds stories with and without action buttons fix: DSS-405
ju-Skinner
force-pushed
the
fix/alert-grid-template-areas
branch
from
c5e72d6
to
4d47872
Compare
pixelflips
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://kajabi.atlassian.net/browse/DSS-405
Description
When the Alert has no actions, the additional row was still being displayed. This is not the intended behavior.
Screenshots
Testing in
sage-libTesting in
kajabi-productsI need to find a location in the app that has an Alert with no action buttons. At this time I'm unaware of it. I'll try to update prior to merging.