Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-410] Export Divider Component #1743

Merged
merged 1 commit into from
May 25, 2023
Merged

[DSS-410] Export Divider Component #1743

merged 1 commit into from
May 25, 2023

Conversation

majabi
Copy link
Contributor

@majabi majabi commented May 24, 2023

Description

This PR addresses exporting the Divider Component for use in monolith.

Screenshots

Before After

Testing in sage-lib

  • verify the Divider component is still functional and renders as expected in storybook.

Testing in kajabi-products

  1. (LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.
    • One more examples of the component in use to either test the change or verify the change has not had adverse effects.
  • LOW: verify that you can successfully import { Divider } from '@kajabi/sage-react

Related

Slack Thread

@majabi majabi requested a review from a team May 24, 2023 20:15
@majabi majabi self-assigned this May 24, 2023
@majabi majabi added the Component Component-specific issue label May 24, 2023
pixelflips
pixelflips approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pixelflips pixelflips requested a review from a team May 24, 2023 21:00
QuintonJason
QuintonJason approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@majabi majabi merged commit b06e119 into develop May 25, 2023
@pixelflips pixelflips mentioned this pull request May 25, 2023
Merged
4 tasks
@pixelflips pixelflips mentioned this pull request Jun 9, 2023
Merged
@ju-Skinner ju-Skinner deleted the DSS-410-export-divider-component branch October 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anechol anechol anechol approved these changes

@QuintonJason QuintonJason QuintonJason approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@majabi majabi

Labels
Component Component-specific issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majabi @pixelflips @QuintonJason @anechol