New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-426]: fix(toggle): Add conditional for customContent #1751

Merged

pixelflips merged 1 commit into develop from DSS-426_pl-radio-custom-slot

Jun 20, 2023

Member

pixelflips commented Jun 17, 2023 •

edited

Loading

Description

Adds conditional for customContent to prevent empty div from being displayed.

Screenshots

Before	After

Testing in `sage-lib`

Radio:

Navigate to Radio
Verify empty custom content div (sage-radio__custom-content) no longer displays in DOM when there is no custom content

Checkbox:

Navigate to Checkbox
Verify empty custom content div (sage-checkbox__custom-content) no longer displays in DOM when there is no custom content

Testing in `kajabi-products`

(LOW) Add conditional to remove empty markup when there is no custom content for radio and checkbox. No effect on KP expected

Related


          fix(toggle): add condition for customContent

225e53d

pixelflips added the bug label

pixelflips self-assigned this

pixelflips marked this pull request as ready for review

June 17, 2023 00:13

pixelflips requested a review from a team

June 17, 2023 00:13

ju-Skinner approved these changes

View reviewed changes

ju-Skinner requested a review from a team

June 20, 2023 20:18

QuintonJason approved these changes

View reviewed changes

pixelflips merged commit a0126f5 into develop

pixelflips deleted the DSS-426_pl-radio-custom-slot branch

June 20, 2023 20:23

pixelflips mentioned this pull request

Next Version Bump #1750

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug