Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-439] Icons: Update icon font (v.19, 5 new) #1768

Merged
merged 5 commits into from
Jul 20, 2023
Merged

[DSS-439] Icons: Update icon font (v.19, 5 new) #1768

merged 5 commits into from
Jul 20, 2023

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Jul 19, 2023 •
edited
Loading

Description

Updates the Sage fonts and adds 5 new icons to the system:

  • app-store
  • play-store
  • ios-battery
  • ios-data
  • ios-wifi

Screenshots

Name
app-store Screenshot 2023-07-20 at 11 43 23 AM
play-store Screenshot 2023-07-20 at 11 43 42 AM
ios-battery Screenshot 2023-07-20 at 11 41 34 AM
ios-data Screenshot 2023-07-20 at 11 41 11 AM
ios-wifi Screenshot 2023-07-20 at 11 41 22 AM

Testing in sage-lib

Docs Site:

  1. Navigate to icons
  2. Verify new icons are added to the system
  3. Verify all icons are rendering as expected
  4. Verify Sage font is served from the /v19 directory from CDN (Network panel in dev tools)

Storybook:

  1. Navigate to icons
  2. Verify new icons are added to the system
  3. Verify all icons are rendering as expected

Testing in kajabi-products

  1. (LOW) Updated icon font w/ 5 new icons (v19). No KP impact is expected.

Related

https://kajabi.atlassian.net/browse/DSS-439

@pixelflips pixelflips self-assigned this Jul 19, 2023
@pixelflips pixelflips requested a review from a team July 19, 2023 21:25
@ju-Skinner ju-Skinner requested a review from a team July 19, 2023 21:55
@pixelflips pixelflips requested a review from ju-Skinner July 20, 2023 18:50
anechol
anechol approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pixelflips pixelflips merged commit 8a8d33e into develop Jul 20, 2023
@pixelflips pixelflips mentioned this pull request Jul 20, 2023
Merged
@pixelflips pixelflips changed the title [DSS-439] Icons: Update icon font (v.19, 2 new) [DSS-439] Icons: Update icon font (v.19, 5 new) Jul 20, 2023
@pixelflips pixelflips deleted the DSS-439_pl-update-sage-icon-font-v19 branch July 21, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintonJason QuintonJason QuintonJason approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@anechol anechol anechol approved these changes

Assignees

@pixelflips pixelflips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pixelflips @QuintonJason @ju-Skinner @anechol