Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next Version Bump #1772

Merged
merged 17 commits into from
Jul 31, 2023
Merged

Next Version Bump #1772

merged 17 commits into from
Jul 31, 2023

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Jul 31, 2023 •
edited by pixelflips
Loading

  1. (LOW) - feat: add component attributes to sage_form_select component #1770 - Allows the ability to add additional attributes to the Components' element.
  2. (LOW) - [DSS-441] Expandable Card Update #1769 - Updates expandable card to support custom header content and trigger alignment.
    • These are new props and slot and should not have any effect. Quick sanity of areas using Accordian or Expandable card should be checked.

pixelflips and others added 16 commits July 25, 2023 15:39
@pixelflips
fix(expandablecard): add new props and conditionals
05305a7
@pixelflips
fix(expandablecard): add new styles
d0c87e0
@pixelflips
docs(expandablecard): add new story
0397bae
@pixelflips
chore(expandablecard): hello linter my old friend
976aac9
@pixelflips
fix(expandablecard): update to use customHeader and alignTrigger
e649ee2
@pixelflips
chore(expandablecard): hello linter my old friend
84ad740
@kajabi-bot
feat: add custom component attributes hash
493c234 
this allows developers to have access to the element and pass additional attributes to it
@pixelflips
docs(expandablecard): add notes related to custom header usage
a9d2485
@pixelflips
fix(expandablecard): add new prop and conditionals rails
e7c115d
@pixelflips
docs(expandablecard): add notes related to custom header usage rails
4108896
@pixelflips
fix(expandablecard): styling adjustments
9bf245e
@pixelflips
fix(expandablecard): remove duplicate class name
35020ad
@pixelflips
fix(expandablecard): update targeting to account for new markup
cc4f20b
@kajabi-bot
feat: allow the form select component to receive additional attributes
6924856
@pixelflips
docs(expandablecard): prop docs adjustment
92c84b4
@ju-Skinner
Merge pull request #1770 from Kajabi/feature/add-component-attributes
6073aa4 
feat: add component attributes to sage_form_select component
@ju-Skinner ju-Skinner requested a review from a team July 31, 2023 20:29
@ju-Skinner ju-Skinner self-assigned this Jul 31, 2023
@pixelflips pixelflips requested a review from a team July 31, 2023 21:11
pixelflips
pixelflips approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ju-Skinner ju-Skinner merged commit 65205d6 into main Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anechol anechol anechol approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@ju-Skinner ju-Skinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ju-Skinner @pixelflips @anechol @kajabi-bot