Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSS-654]feat: add Card.Header component with updates to storybook #1895

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

aperez-kajabi
Copy link
Collaborator

Description

Implement a Card.Header sub component for a non-opinionated header with a configurable background.
It should allow for a configurable background prop that will either

  • match an existing CODE from SageTokens.COLOR_SLIDERS
  • allow a custom HEX value if the provided background prop does not match to a COLOR_SLIDERS key
    This will function exactly as the background prop in the component.

Implementation example:

<Card.Header background={SageTokens.COLOR_SLIDERS.GREY_200}>
    {...}
</Card.Header>

Screenshots

Before After
image image

Testing in sage-lib

Testing in kajabi-products

  1. (LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.
    • One more examples of the component in use to either test the change or verify the change has not had adverse effects.

Related

@aperez-kajabi aperez-kajabi added enhancement New feature or request javascript Pull requests that update Javascript code labels Jun 12, 2024
@aperez-kajabi aperez-kajabi requested a review from a team June 12, 2024 20:45
@aperez-kajabi aperez-kajabi self-assigned this Jun 12, 2024
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks good

@aperez-kajabi aperez-kajabi merged commit a77a8b2 into develop Jun 25, 2024
6 checks passed
@pixelflips pixelflips mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants