Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): adds back rest to icon component #1898

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Jun 21, 2024

Description

When converting icons to pds-icon, ...rest got removed unintentionally. Bringing back to resolve some issues this causes in KP.

Screenshots

No visual changes

Testing in sage-lib

Verify ...rest is available in code.

Testing in kajabi-products

  1. (LOW) Adds rest back to the icon component.

Related

N/A

@pixelflips pixelflips added the bug Something isn't working label Jun 21, 2024
@pixelflips pixelflips self-assigned this Jun 21, 2024
@pixelflips pixelflips marked this pull request as ready for review June 21, 2024 18:03
@pixelflips pixelflips requested a review from a team June 21, 2024 18:04
@pixelflips pixelflips merged commit 432f355 into develop Jun 21, 2024
6 checks passed
@pixelflips pixelflips mentioned this pull request Jun 21, 2024
ju-Skinner pushed a commit that referenced this pull request Jun 21, 2024
* chore: update Storybook source path for local and prod environment

* Disable lint warnings for dependencies (#1889)

* chore: update Storybook source path for local and prod environment

* fix: resolve linting errors

* fix: revert preview-head file change

---------

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

* fix(label): convert icon to pine (#1896)

* fix(Icon): adds back rest to icon component (#1898)

* fix: adds back rest to icon

* fix: add rest to element

---------

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: Monica Wheeler <monica.wheeler@kajabi.com>
@monicawheeler monicawheeler deleted the fix/pl-icon-rest-fix branch June 21, 2024 19:09
This was referenced Jun 21, 2024
ju-Skinner pushed a commit that referenced this pull request Jun 21, 2024
* fix: adds back rest to icon

* fix: add rest to element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants