fix(dropdownitem): convert before element to pds-icon #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicawheeler
approved these changes
Aug 1, 2024
ju-Skinner
approved these changes
Aug 2, 2024
QuintonJason
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Icons are not rendering properly in react
dropdownitemcomponent afterpds-iconconversion. The pds-icon needed to be added to the component.Screenshots
Testing in
sage-libNavigate to Dropdown Component
Verify the icons are now displaying in the dropdowns
Testing in
kajabi-productsRelated
sage-support request