Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): add missing icon for help link variant #1943

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Aug 9, 2024

Description

The rails link component was missing the icon for the help link variation.
This update adds back the missing question-circle icon.
Page headings were not affected by this bug.

Screenshots

Before
Screenshot 2024-08-09 at 9 47 56 AM

Testing in sage-lib

Navigate to link docs
Verify icon displays in help link section demos

Testing in kajabi-products

  1. (MEDIUM) Add missings icon for help link variant.
    • Spot-check any panels or single usage of help links. Automation panel in course edit view or assessments edit view.

Related

@pixelflips pixelflips self-assigned this Aug 9, 2024
@pixelflips pixelflips marked this pull request as ready for review August 9, 2024 16:52
@pixelflips pixelflips requested a review from a team August 9, 2024 16:54
Copy link
Contributor

@FuturaExtraBold FuturaExtraBold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixelflips pixelflips merged commit f3be8b7 into develop Aug 9, 2024
7 checks passed
@pixelflips pixelflips deleted the fix/help-link-icon branch August 9, 2024 17:21
@pixelflips pixelflips mentioned this pull request Aug 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants