Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(badge): down icon needed to remove the width #1963

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(badge): down icon needed to remove the width #1963

merged 1 commit into from
Aug 29, 2024

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Aug 28, 2024 •
edited
Loading

Description

In Sage Support channel, we had an issue with the icon being to wide.

Screenshots

Before After
image image

Testing in sage-lib

  1. Navigate to the Badge component in the Doc Site -> http://localhost:4000/pages/component/badge?tab=preview
  2. Confirm that the down chevron appears as it does in the screenshot.

Testing in kajabi-products

  1. (LOW) Confirm that the dropdown icons look small

Related

@ju-Skinner ju-Skinner self-assigned this Aug 28, 2024
@ju-Skinner ju-Skinner requested a review from a team August 28, 2024 17:47
@pixelflips pixelflips requested a review from a team August 28, 2024 17:59
@ju-Skinner ju-Skinner merged commit 9af6cd3 into develop Aug 29, 2024
7 checks passed
@ju-Skinner ju-Skinner mentioned this pull request Aug 29, 2024
Merged
ju-Skinner added a commit that referenced this pull request Sep 3, 2024
@ju-Skinner @kajabi-bot @dependabot
chore: version bump (#1966)
dbf87c8 
* chore: update node version to 22.7.0

* chore(deps): bump @pine-ds/icons from 8.0.0 to 8.1.0 (#1961)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.0.0 to 8.1.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.0.0...v8.1.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump webpack from 4.44.2 to 5.94.0 in /docs (#1964)

Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.44.2...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(badge): down icon needed to remove the width (#1963)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ju-Skinner added a commit that referenced this pull request Sep 3, 2024
@ju-Skinner @kajabi-bot @dependabot
chore: version bump (#1966)
41b443c 
* chore: update node version to 22.7.0

* chore(deps): bump @pine-ds/icons from 8.0.0 to 8.1.0 (#1961)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.0.0 to 8.1.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.0.0...v8.1.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump webpack from 4.44.2 to 5.94.0 in /docs (#1964)

Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.44.2...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(badge): down icon needed to remove the width (#1963)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ju-Skinner added a commit that referenced this pull request Sep 3, 2024
@ju-Skinner @kajabi-bot @dependabot
chore: version bump (#1966)
df1492a 
* chore: update node version to 22.7.0

* chore(deps): bump @pine-ds/icons from 8.0.0 to 8.1.0 (#1961)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.0.0 to 8.1.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.0.0...v8.1.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump webpack from 4.44.2 to 5.94.0 in /docs (#1964)

Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.44.2...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(badge): down icon needed to remove the width (#1963)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

Assignees

@ju-Skinner ju-Skinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ju-Skinner @pixelflips @kajabi-bot