Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add logical properties to components #1979

Merged
merged 14 commits into from
Oct 25, 2024
Merged

fix: add logical properties to components #1979

merged 14 commits into from
Oct 25, 2024

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Sep 13, 2024 •
edited
Loading

Description

  • update components to use logical properties
  • update component js to swap margin or padding direction if necessary

Screenshots

Catalog Item

Before After
Screenshot 2024-09-12 at 8 23 04 PM Screenshot 2024-09-12 at 8 25 12 PM

Toolbar

Before After
Screenshot 2024-09-12 at 7 56 24 PM Screenshot 2024-09-12 at 8 20 45 PM

Nav link

Before After
Screenshot 2024-09-12 at 6 50 08 PM Screenshot 2024-09-12 at 6 50 31 PM

Testing in sage-lib

  • Add dir="rtl" to <html> docs/app/views/layouts/application.html.erb to activate RTL
  • Click around the app to verify that nothing is misaligned and looks/behaves as expected
  • In default left-to-right viewing there should be no visual regression

Testing in kajabi-products

  1. (LOW) Adds logical properties. No visual change

Related

Closes DSS-905

@QuintonJason QuintonJason self-assigned this Sep 13, 2024
@github-actions github-actions bot added the mercury-rising Used for rebrand work label Sep 13, 2024
@QuintonJason QuintonJason force-pushed the fix/add-logical-properties-to-compoents branch from e2fb146 to e3500a9 Compare September 18, 2024 14:20
@QuintonJason QuintonJason requested a review from a team September 18, 2024 14:20
@QuintonJason QuintonJason marked this pull request as ready for review September 18, 2024 14:21
@QuintonJason QuintonJason changed the base branch from mercury-rising to develop September 18, 2024 14:39
@QuintonJason QuintonJason force-pushed the fix/add-logical-properties-to-compoents branch from e3500a9 to 9ffae75 Compare September 18, 2024 14:54
pixelflips
pixelflips approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linting errors, otherwise LGTM! 👍🏼

@pixelflips pixelflips requested a review from a team September 18, 2024 16:01
anechol
anechol requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work getting these updated! 🔥

There's still a couple of missed instances, mainly in Icon and Empty State.

anechol
anechol approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@QuintonJason QuintonJason removed the mercury-rising Used for rebrand work label Oct 1, 2024
@QuintonJason QuintonJason force-pushed the fix/add-logical-properties-to-compoents branch from b7c17a3 to 3da607a Compare October 15, 2024 21:50
@QuintonJason QuintonJason force-pushed the fix/add-logical-properties-to-compoents branch from b4f927f to 93fcaaf Compare October 23, 2024 16:10
@QuintonJason QuintonJason mentioned this pull request Oct 25, 2024
Merged
@QuintonJason QuintonJason merged commit bb806c3 into develop Oct 25, 2024
7 checks passed
@QuintonJason QuintonJason deleted the fix/add-logical-properties-to-compoents branch October 25, 2024 13:21
ju-Skinner pushed a commit that referenced this pull request Oct 28, 2024
@QuintonJason @kajabi-bot
fix: add logical properties to components (#1979)
17885ab 
* fix: update physical properties to logical properties

* fix: to logical border radius

* style: add override to body

* style: update inset values back to physical values

* fix: update input js

* style: update property

* fix: remove rtl call

* fix: add rtl spacer styles

* fix: update input group padding

* fix: update rtl tooltip arrow positioning

* fix: update variable name

* fix: added missing logical props

* fix: remove icon flex reverse

* fix: linter fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anechol anechol anechol approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @pixelflips @anechol