fix: tooltip custom class (react) #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
commented
Oct 18, 2024
|
|
||
| export const Tooltip = ({ | ||
| children, | ||
| content, | ||
| position, | ||
| tooltipCustomClass, |
There was a problem hiding this comment.
I'm definitely open to naming suggestions. I noticed tabChoiceCustomClass and went with a similar approach.
ju-Skinner
approved these changes
Oct 19, 2024
monicawheeler
approved these changes
Oct 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is no hook into the react tooltip to allow custom adjustments.
This adds a
tooltipCustomClassprop to allow devs a hook.This comes as a request from ds-support.
Screenshots
Testing in
sage-libTesting in
kajabi-productsRelated
TBD