Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge: border and color updates #2022

Merged
merged 10 commits into from
Nov 26, 2024
Merged

Badge: border and color updates #2022

merged 10 commits into from
Nov 26, 2024

Conversation

monicawheeler
Copy link
Collaborator

@monicawheeler monicawheeler commented Nov 9, 2024 •
edited
Loading

Description

Update badge to align with update to designs which request a border to be added to the sidebar.

Changes made

  • Reorganize the documentation to better align with how other docs like buttons are organized
  • Update several color combo hex values to align with colors found in Figma
  • Remove the badge-insert-border variable
  • Add border width, style, and dynamic scss color
  • Update the typography used for both size badges (font-size, letter-spacing, and font-family updated)
  • Change text color in badge to align with corresponding background color

Screenshots

Before After
Screenshot 2024-11-08 at 8 52 54 PM Screenshot 2024-11-25 at 2 19 12 PM

Gif

badge

Testing in sage-lib

  1. Navigate to http://localhost:4000/pages/component/badge?tab=preview
  2. Verify the badges align with the chip component, Figma file

Testing in kajabi-products

  1. (MEDIUM)
    • Badge is used in multiple areas for statuses and list item labeling. It would be beneficial to get a pass through with QE to ensure that nothing breaks with this update.

Related

DSS-1159

@monicawheeler monicawheeler self-assigned this Nov 9, 2024
@monicawheeler monicawheeler marked this pull request as ready for review November 22, 2024 02:11
@monicawheeler monicawheeler requested a review from a team November 22, 2024 02:11
@monicawheeler monicawheeler changed the title style(badge): rework documentation and styles for border and color updates Badge: border and color updates Nov 22, 2024
@monicawheeler monicawheeler requested a review from a team November 25, 2024 16:14
@pixelflips pixelflips requested a review from a team November 25, 2024 16:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
See the Details below.

License Issues

docs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-packs^6.1.3NullUnknown License

packages/sage-packs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^6.1.3NullUnknown License
@kajabi/sage-react^6.1.3NullUnknown License

packages/sage-react/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^6.1.3NullUnknown License
Denied Licenses: LGPL-2.0, AAL, Adobe-2006, Afmparse, Artistic-1.0, Artistic-1.0-cl8, Artistic-1.0-Perl, Beerware, blessing, Borceux, CECILL-B, ClArtistic, Condor-1.1, Crossword, CrystalStacker, diffmark, DOC, EFL-1.0, EFL-2.0, Fair, FSFUL, FSFULLR, Giftware, HPND, IJG, Leptonica, LPL-1.0, LPL-1.02, MirOS, mpich2, NASA-1.3, NBPL-1.0, Newsletr, NLPL, NRL, OGTSL, OLDAP-1.1, OLDAP-1.2, OLDAP-1.3, OLDAP-1.4, psutils, Qhull, Rdisc, RSA-MD, Spencer-86, Spencer-94, TU-Berlin-1.0, TU-Berlin-2.0, Vim, W3C-19980720, W3C-20150513, Wsuipa, WTFPL, xinetd, Zed, Zend-2.0, ZPL-1.1, AGPL-1.0-only, AGPL-1.0-or-later, AGPL-3.0-only, AGPL-3.0-or-later, APSL-1.0, APSL-1.1, APSL-1.2, APSL-2.0, CPAL-1.0, EUPL-1.0, EUPL-1.1, EUPL-1.2, NPOSL-3.0, OSL-1.0, OSL-1.1, OSL-2.0, OSL-2.1, OSL-3.0, RPSL-1.0, SSPL-1.0, CAL-1.0, CAL-1.0-Combined-Work-Exception, Parity-6.0.0, Parity-7.0.0, RPL-1.1, RPL-1.5, EPL-1.0, EPL-2.0, ErlPL-1.1, IPL-1.0, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0-or-later, LGPL-3.0, MPL-1.0, MPL-1.1, MPL-2.0, MPL-2.0-no-copyleft-exception, MS-RL, SPL-1.0, BSD-Protection, copyleft-next-0.3.0, copyleft-next-0.3.1, GPL-1.0-only, GPL-1.0-or-later, GPL-1.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-only, GPL-3.0-or-later, GPL-3.0, QPL-1.0, Sleepycat

Scanned Manifest Files

docs/package.json
  • @kajabi/sage-packs@^6.1.3
  • @kajabi/sage-packs@^6.1.2
packages/sage-packs/package.json
  • @kajabi/sage-assets@^6.1.3
  • @kajabi/sage-react@^6.1.3
  • @kajabi/sage-assets@^6.1.2
  • @kajabi/sage-react@^6.1.2
packages/sage-react/package.json
  • @kajabi/sage-assets@^6.1.3
  • @kajabi/sage-assets@^6.1.2

@monicawheeler
Copy link
Collaborator Author

Cam reviewed and approved this PR's 👍

@monicawheeler monicawheeler merged commit c55c8ac into develop Nov 26, 2024
7 checks passed
@monicawheeler monicawheeler deleted the dss-1159-chip-border branch November 26, 2024 15:26
@monicawheeler monicawheeler mentioned this pull request Nov 26, 2024
Merged
pixelflips pushed a commit that referenced this pull request Nov 26, 2024
@monicawheeler @kajabi-bot @pixelflips
Badge: border and color updates (#2022)
1ae1e98 
* chore(ci): updating rails gem version [ci skip]

* chore(release): publish [skip ci]

* style(badge): rework documentation and styles for border and color updates

* fix(linter): remove extra spaces and reorg style order

* style(badge): rearrange badge preview and update styles

* fix: linting issue in the scss for order of props

* docs(badge): minor adjustments to grammar

* style(dot): adjust sage-badge dot spacing to align with designs

* revert versions to match develop

* fix: remove extra space in changelog

---------

Co-authored-by: Kajabi Automation Bot <dev+github-bot@kajabi.com>
ju-Skinner pushed a commit that referenced this pull request Dec 13, 2024
@monicawheeler @kajabi-bot
@pixelflips @dependabot
Next Version Bump (#2027)
e09625d 
* Badge: border and color updates (#2022)

* chore(ci): updating rails gem version [ci skip]

* chore(release): publish [skip ci]

* style(badge): rework documentation and styles for border and color updates

* fix(linter): remove extra spaces and reorg style order

* style(badge): rearrange badge preview and update styles

* fix: linting issue in the scss for order of props

* docs(badge): minor adjustments to grammar

* style(dot): adjust sage-badge dot spacing to align with designs

* revert versions to match develop

* fix: remove extra space in changelog

---------

Co-authored-by: Kajabi Automation Bot <dev+github-bot@kajabi.com>

* docs: update broken image paths (#2029)

* chore(deps): bump @pine-ds/icons from 8.11.0 to 8.12.0 (#2028)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.11.0 to 8.12.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.11.0...v8.12.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kajabi Automation Bot <dev+github-bot@kajabi.com>
Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

Assignees

@monicawheeler monicawheeler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monicawheeler @pixelflips @ju-Skinner @kajabi-bot