Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adds greet condensed font to Sage #2034

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Jan 14, 2025

Description

Adds Greet Condensed to Sage repo.

Screenshots

Example for font display purposes:

Before After
Screenshot 2025-01-14 at 11 51 33 AM Screenshot 2025-01-14 at 11 52 06 AM

Testing in sage-lib

  • Pick a component to test (e.g. Button)
  • Update CSS font-family to Greet-Condensed
  • Check that font network request is 200 and renders as expected

Testing in kajabi-products

  1. (LOW) Adds Greet Condensed to Sage repo.

Related

DSS-1223

@anechol anechol requested review from monicawheeler and a team January 14, 2025 17:59
@anechol anechol self-assigned this Jan 14, 2025
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish these were added in their own bucket on S3.

Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise LGTM.


// Light
@font-face {
font-family: "Greet-Condensed";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the font-family also use the variable? Not a blocker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It very well could, but none of the others do currently. Maybe this can be a small update for the future?

@anechol anechol merged commit 250ecbd into develop Jan 14, 2025
7 checks passed
@anechol anechol deleted the style/add-greet-condensed branch January 14, 2025 19:17
@anechol anechol mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants