-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Guava dependency #129
Conversation
Prepare release
fix(core): add support for jvm toolchain 8
Hi there. In a case like this, you can override transient dependency in your own project (you can look up how to do that here - https://stackoverflow.com/questions/30728533/gradle-override-transitive-dependency-by-version-classifier). But on the other hand, I don't see a reason why we imported it in the first place, as it seems from this PR that we use only 1 function of the whole library which can be replaced by Kotlin STD function. @Vacxe wdyt? |
100% agree with replacement. If all checks passed I'll be happy to remove that dependency. Thanks for letting us know @kubode ! Cheers. |
Released 3.6.2 |
Guava has some dependency issues as mentioned at here.
Guava has been introduced in Kakao 3.6.0 at fd7edfd.
Bumping up to 3.6.0 caused the dependency resolution issue on our project.
So we want to remove Guava from the dependency of Kakao.