Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guava dependency #129

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Remove Guava dependency #129

merged 11 commits into from
Aug 7, 2024

Conversation

kubode
Copy link
Contributor

@kubode kubode commented Aug 2, 2024

Guava has some dependency issues as mentioned at here.

Guava has been introduced in Kakao 3.6.0 at fd7edfd.
Bumping up to 3.6.0 caused the dependency resolution issue on our project.
So we want to remove Guava from the dependency of Kakao.

@Unlimity
Copy link
Contributor

Unlimity commented Aug 7, 2024

Hi there. In a case like this, you can override transient dependency in your own project (you can look up how to do that here - https://stackoverflow.com/questions/30728533/gradle-override-transitive-dependency-by-version-classifier). But on the other hand, I don't see a reason why we imported it in the first place, as it seems from this PR that we use only 1 function of the whole library which can be replaced by Kotlin STD function. @Vacxe wdyt?

@Vacxe
Copy link
Member

Vacxe commented Aug 7, 2024

100% agree with replacement. If all checks passed I'll be happy to remove that dependency. Thanks for letting us know @kubode ! Cheers.

@Vacxe Vacxe changed the base branch from master to develop August 7, 2024 09:17
@Vacxe Vacxe merged commit a4f6096 into KakaoCup:develop Aug 7, 2024
@kubode kubode deleted the kubode/remove-guava branch August 7, 2024 09:22
@Vacxe
Copy link
Member

Vacxe commented Aug 7, 2024

Released 3.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants