-
Notifications
You must be signed in to change notification settings - Fork 2
Db cluster implementation #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
riki7649255
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB/ELTS/.ipynb_checkpoints/Untitled-checkpoint.ipynb
- ignore file- don't push it
DB/ELTS/Untitled.ipynb
2. ignore file
- are you the owner of cluster & instance both? if not, did you sync with cluster owner? she knows you touched her files?
DB/NEW_KT_DB/Controller/DBSubnetGroupController.py
4. you are not the owner of subnet group, why did you push the whole file?
please fix your pr- you can create new one only with your files and send for me to review
|
1, 2 - נכון, אני אמחק
3. אני אחראית על cluster - ומשתמשת בתוכו ב Instance - אז אני צריכה את שתי
המחלקות כדי להריץ, ובאמת כדאי שאני אמחק אותם ממני למקרה שהיא שינתה עוד
משהו...
4.נכון, מוחקת
עשיתי את השינויים
אשמח לאישור
בתאריך יום ד׳, 18 בספט׳ 2024 ב-22:16 מאת riki7649255 <
***@***.***>:
… ***@***.**** requested changes on this pull request.
DB/ELTS/.ipynb_checkpoints/Untitled-checkpoint.ipynb
1. ignore file- don't push it
DB/ELTS/Untitled.ipynb
2. ignore file
3. are you the owner of cluster & instance both? if not, did you sync
with cluster owner? she knows you touched her files?
DB/NEW_KT_DB/Controller/DBSubnetGroupController.py
4. you are not the owner of subnet group, why did you push the whole file?
please fix your pr- you can create new one only with your files and send
for me to review
—
Reply to this email directly, view it on GitHub
<#334 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE6TF6YS5IC7AIPIULJNEXLZXHGRNAVCNFSM6AAAAABONWFZPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJTGU2TOOJSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No description provided.