Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hide_confirm the default in select_multiple #9

Closed
provinzkraut opened this issue Nov 16, 2018 · 3 comments
Closed

Make hide_confirm the default in select_multiple #9

provinzkraut opened this issue Nov 16, 2018 · 3 comments
Labels

Comments

@provinzkraut
Copy link
Contributor

One key should represent one action, and having the tick action bound to ENTER and SPACE is redundant, plus it is a few extra steps to confirm input.

Selecting with SPACE and confirming with ENTER is more intuitive and faster, so i think this should be the default option.

@Kamik423
Copy link
Owner

My reasoning for this was:

It is (in my opinion) more intuitive to have ENTER for confirmation. It is more similar to what we are used to from graphical interfaces. For example when I select from the (single) select list I use ENTER. The confirm button also is more straight forward. A new user encountering the select_multiple for the first time would probably not know what to do, try ENTER and confirm the menu. An explanation would have to be added every time like "SPACE to select, ENTER to confirm", which in my opinion is less elegant.

Concerning redundancy: as requested on Reddit I wanted to add vim shortcuts that (for better or worse) are used by many people and supported by many interfaces.

What do you think?

@evaherrada
Copy link
Contributor

To add on to what Kamik423 said, if you don't want ENTER to tick, set hide_confirm to True and then you can select with space and submit with enter

@provinzkraut
Copy link
Contributor Author

@Kamik423

I don't think users that are used to graphical UI are the main concern here. It is for terminal interactions, and in the terminal world, you are used to press ENTER to confirm and proceed, and select things with SPACE.

I don't think many users that haven't used a terminal are coming across this.
If you would want to adress this, you could give an option to display instructions if the dev is expecting less experienced users.

Lastly, I disagree that a confirm button is more straightforward. The great strength of user interfaces with keybindings is that the actions are just one key away. With the confirm button, they are potentially very far away, as a user may be prompted with a long list, ticks an item at the top and has then to scroll all the way down to confirm his actions.

@dherrada

My concern was that this should be the default option ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants