Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak per player #124

Closed
chess123mate opened this issue Feb 22, 2021 · 1 comment
Closed

Memory leak per player #124

chess123mate opened this issue Feb 22, 2021 · 1 comment
Labels
bug

Comments

@chess123mate
Copy link

In DataStore2/init.lua:549 keeps the bound function in memory for the rest of the server's lifetime, along with everything needed to let the function run (the player instance and datastore table).
@connor-gro connor-gro mentioned this issue May 16, 2021
Merged
Kampfkarren added a commit that referenced this issue May 23, 2021
@connor-gro @Kampfkarren
BindToClose issue fixes (#134)
c24d0f4 
* Removed comment that 'require' is a valid way to get DataStore2

* Fixes Issue #124 - "Memory leak per player"

* Fixes #125 - Use a BindableEvent instead of setting Player.Parent to nil

* Fixes Issue #126 - Handles potential BindToClose error

* Added additional info to BindToClose failure warning

Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>

* Applied suggestions to change `booleanVal == false` to `not booleanVal`

Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>

* Applied code review suggestions

* Removed unnecessary promise catch

* Added Promise.defer to replace spawn
Also added comment to prevent accidental changes to deferred code

Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>
@itzfnr
Copy link

itzfnr commented Jun 11, 2022

Issue resolved - should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kampfkarren @chess123mate @itzfnr