Fix refresh breaking when story produces an error. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a story throws an error, the live refresh fails until the user reselects the story. This happens because the setup of the Changed event occurs after parsing the story source. If parsing fails, then the function returns before the Changed event is ever set up. This change simply moves setup of the Changed event to occur before parsing.
|
Great catch! This has always bugged the heck out of me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a story throws an error, the live refresh fails until the user
reselects the story. This happens because the setup of the Changed
event occurs after parsing the story source. If parsing fails, then the
function returns before the Changed event is ever set up.
This change simply moves setup of the Changed event to occur before
parsing.