Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make collectgarbage arguments optional (#287) #300

Merged

Conversation

zhiburt
Copy link
Contributor

@zhiburt zhiburt commented Oct 1, 2021

Hi @Kampfkarren, thank you for the library.
And thank you for mark Good First Issue.
Found the repo via hackotoberfest mark.

Please let me know if I did something wrong.

closes #287

@zhiburt zhiburt changed the title Make collectgarbage arguments optional (#287) Make collectgarbage arguments optional (#287) Oct 1, 2021
@Kampfkarren
Copy link
Owner

Looks good, in Roblox we're required to put a variable there, so I must have missed it.

Can you put this in the CHANGELOG too? Under "Changed"?

@Kampfkarren
Copy link
Owner

Same oops as in the other PR--put it in Unreleased instead of 0.14.0.

@Kampfkarren Kampfkarren merged commit a189bf3 into Kampfkarren:main Oct 2, 2021
@Kampfkarren
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collectgarbage() requires at least 1 parameter while Lua has parameters optional for it
2 participants