DevTools supports ENV-injected version for better internal bug reports (

facebook#22635)
KamranAsif · Nov 4, 2021 · 4488aab · 4488aab
1 parent 39b5591
commit 4488aab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/packages/react-devtools-extensions/utils.js b/packages/react-devtools-extensions/utils.js
@@ -30,12 +30,14 @@ function getGitCommit() {
  }
 }
 
-function getVersionString() {
- const packageVersion = JSON.parse(
- readFileSync(
- resolve(__dirname, '..', 'react-devtools-core', './package.json'),
- ),
- ).version;
+function getVersionString(packageVersion = null) {
+ if (packageVersion == null) {
+ packageVersion = JSON.parse(
+ readFileSync(
+ resolve(__dirname, '..', 'react-devtools-core', './package.json'),
+ ),
+ ).version;
+ }
 
  const commit = getGitCommit();
 

diff --git a/packages/react-devtools-extensions/webpack.backend.js b/packages/react-devtools-extensions/webpack.backend.js
@@ -30,7 +30,7 @@ const builtModulesDir = resolve(
 
 const __DEV__ = NODE_ENV === 'development';
 
-const DEVTOOLS_VERSION = getVersionString();
+const DEVTOOLS_VERSION = getVersionString(process.env.DEVTOOLS_VERSION);
 
 const featureFlagTarget = process.env.FEATURE_FLAG_TARGET || 'extension-oss';
 

diff --git a/packages/react-devtools-extensions/webpack.config.js b/packages/react-devtools-extensions/webpack.config.js
@@ -30,7 +30,7 @@ const builtModulesDir = resolve(
 
 const __DEV__ = NODE_ENV === 'development';
 
-const DEVTOOLS_VERSION = getVersionString();
+const DEVTOOLS_VERSION = getVersionString(process.env.DEVTOOLS_VERSION);
 
 const LOGGING_URL = process.env.LOGGING_URL || null;