Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better s3source for pmtiles #104

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: better s3source for pmtiles #104

merged 2 commits into from
Aug 25, 2024

Conversation

Kanahiro
Copy link
Owner

No description provided.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 12.82051% with 34 lines in your changes missing coverage. Please review.

Project coverage is 58.76%. Comparing base (83cc6f7) to head (8bd5e9b).
Report is 5 commits behind head on main.

Files Patch % Lines
src/source/pmtiles.ts 12.82% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   59.49%   58.76%   -0.74%     
==========================================
  Files          19       19              
  Lines        1459     1484      +25     
  Branches       92       92              
==========================================
+ Hits          868      872       +4     
- Misses        588      609      +21     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kanahiro Kanahiro merged commit a2c07be into main Aug 25, 2024
2 of 4 checks passed
@Kanahiro Kanahiro deleted the fix/pmtiles/s3 branch August 25, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant