Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #18 and #63 #108

Merged
merged 2 commits into from Jun 8, 2015
Merged

Fixes for #18 and #63 #108

merged 2 commits into from Jun 8, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2015

No description provided.

@ospalh
Copy link
Member

ospalh commented May 29, 2015

I haven’t said it yet, but thanks for the effort so far.

The fixes for #18 and #63 look good.

… fixing open tickets … an easy one

Sorry, i guess #18 and #63 count as easy, but re #79:

  1. I just didn’t want to drop issues reported by others when i closed Some kanji to check #14 without giving others the chance to comment.
  2. But i think the current state, with the 6th stroke top right to bottom left is OK. Makes sense for handwriting. Taking 筆 as an example, that is a more fluid movement, sort of on the way from strokes 5 to stroke 7.
  3. And there are lots of kanji with “竹 as top element“, not just 筆/07b46.svg from the original report from 2010. I think we should keep them consistent.

And I think most other open issues that are either “won’t fix” where i didn’t want to decide that alone, or not easy.

(copy-edited)

@ghost
Copy link
Author

ghost commented May 29, 2015

I haven’t said it yet, but thanks for the effort so far.

You're welcome. I benefited much from this project when I started learning kanji.

Anyway, let me know how you'd like me to contribute (we can deal with this in private).

The fixes for #18 and #63 look good.

Ok, let me send a new pull request with those two changes only.

And I think most other open issues that are either “won’t fix” where i didn’t want to decide that alone, or not easy.

I reviewed all of them and sent an email to the Google Group. Many seem to have stalled, or lack precisions.

@ghost ghost changed the title Fixes for #18, #63 and #79 Fixes for #18 and #63 May 29, 2015
@ospalh
Copy link
Member

ospalh commented Jun 8, 2015

Oh, sorry.
I didn’t notice earlier that you removed the change for #79.
Yes, these two look god.
Thanks again.

ospalh added a commit that referenced this pull request Jun 8, 2015
@ospalh ospalh merged commit 5207dbc into KanjiVG:master Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant