Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

蜂: Group 三 and 丨 in 丰 #114

Merged
merged 3 commits into from
Jun 11, 2015
Merged

蜂: Group 三 and 丨 in 丰 #114

merged 3 commits into from
Jun 11, 2015

Conversation

melissaboiko
Copy link
Contributor

I made this edit manually, because Inkscape messed up the file. I copied it from 05cf0.svg (峰).

I'm not sure if this is correct, so please review with care :)

@ospalh
Copy link
Member

ospalh commented Jun 11, 2015

Thanks.

ospalh added a commit that referenced this pull request Jun 11, 2015
蜂: Group 三 and 丨 in 丰
@ospalh ospalh merged commit 3494901 into KanjiVG:master Jun 11, 2015
@ospalh
Copy link
Member

ospalh commented Jun 11, 2015

Some more comments:
Instead of the merge, 3ecf8ff, a rebase would have been a bit cleaner. The ea76953 commit should have disappeared from this PR, leaving only 3ba444a (with a new hash).

I made this edit manually,

Yes, changing things like the grouping is best done manually, At least for now.
(Or maybe with a script that treats the XML as text when you want to change many files in the same way.)

because Inkscape messed up the file.

To changes to the appearance (changing stroke shapes, moving numbers) i still use Inkscape, but because the structure does get messed up i copy only the relevant data back with this script. UTSL on how to use it.

For strokes out of order there is the swap_strokes.py script in the repo. Again UTSL or run it with -h for usage information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants