Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angles #249

Merged
merged 39 commits into from
Apr 2, 2022
Merged

Fix angles #249

merged 39 commits into from
Apr 2, 2022

Conversation

benkasminbullock
Copy link
Member

No description provided.

Where strokes have clearly been mislabelled, I've swapped them.

More complicated and confusing cases I've filed as issues.
A large number of characters had a "dash" ㇒ as the left stroke of 月,
whereas the SVG had a downward line. This replaces all the dashes with
a vertical line.
This element makes it easier to fix the stroke type errors
This uses the labels added in the previous commit to fix several
instances of strokes which were mislabelled with kvg:type in the wrong
order.
The strokes in the upper inner part of 䍃 were set as horizontal lines
but they are diagonal.
To be consistent we should also add 㦰 around the two subsequent child
groups, but I have not done that.
In two of the files I've changed 犬 to the correct element 犮.
This changes multiple strokes from 羽 to reflect their direction.
I've checked some web sites, and this appears to contain the correct
Japanese stroke order. Given that, the types on strokes 8 and 9 are
wrong, so I've altered them to what they look like visually.
Various edits of incorrect stroke types
@benkasminbullock benkasminbullock merged commit c2cc7ec into master Apr 2, 2022
@benkasminbullock benkasminbullock deleted the fix-angles branch April 2, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant