-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix angles #249
Merged
Merged
Fix angles #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where strokes have clearly been mislabelled, I've swapped them. More complicated and confusing cases I've filed as issues.
A large number of characters had a "dash" ㇒ as the left stroke of 月, whereas the SVG had a downward line. This replaces all the dashes with a vertical line.
This element makes it easier to fix the stroke type errors
This uses the labels added in the previous commit to fix several instances of strokes which were mislabelled with kvg:type in the wrong order.
The strokes in the upper inner part of 䍃 were set as horizontal lines but they are diagonal.
To be consistent we should also add 㦰 around the two subsequent child groups, but I have not done that.
In two of the files I've changed 犬 to the correct element 犮.
This changes multiple strokes from 羽 to reflect their direction.
I've checked some web sites, and this appears to contain the correct Japanese stroke order. Given that, the types on strokes 8 and 9 are wrong, so I've altered them to what they look like visually.
Various edits of incorrect stroke types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.