Fixes #33
Closed
Fixes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some thoughts rather than working code how i think the xml builder should look.
This needs review. I’m not sure which way stroke 5 is written. And i wonder if the srokes 6 and 7 shouldn’t be swapped, but i didn’t touch the strokes.
|
'the order of strokes 6 and 7 seems a bit wired':
|
The strokes themselves look OK.
Rearrange stroke data to match other info (numbers, types, data in plain 冥)
|
Oh dear, some commits that i didn't mean to be here sneaked in. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these should be rather uncontorversal:
For the changes to 嘘,re issue report #28, i’m not quite sure about the exact positions. I’m not sure which way the stroke 5 is written, and the order of strokes 6 and 7 seems a bit weird to me, but i didn’t touch those.