Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30, #38, #46, #47, +two Jouyou kanji, Stroke Numbers #50, Centering #39, Dots #37 #51

Merged
merged 18 commits into from
Feb 6, 2013

Conversation

eichhirn
Copy link
Contributor

Fixes
#47 02695-_1HzFst.svg error in name
#46 Displaced 751e, 9f4b, 5618
#38 05618-xxx displaced to the right
#40 63b4+848b Jinmei have codepoints of their own

Additions
Missing Jouyou kanji 9830 頰 ("cheek") and 5861 塡 ("fill up"), which was already present as 0586b-Jinmei.
.gitattributes file for line-ending normalization

Stroke Numbers (partial fix of #50)
Recovers the stroke numbers from the old SVG directory. I didn't check for any previous changes to the stroke numbers of these files, any such changes will have been overwritten.
Now there are only 5 files left with missing numbers:
Found not enough numbers to match #strokes 05300 0/4
Found not enough numbers to match #strokes 0583d 12/13
Found not enough numbers to match #strokes 05ac2 3/13
Found not enough numbers to match #strokes 0641c 3/13
Found not enough numbers to match #strokes 096e9 8/11

Centering Kana + Latin letters
#39 Latin letters, punctuation, kana should be centered (also #41)

Restore missing dots
I used Bezier curves instead of circle elements to prevent breakage of existing software. The fill attribute is used in some files, which was previously constant ("none").
#37 Missing dots

@Gnurou Gnurou merged commit 93e2ce2 into KanjiVG:master Feb 6, 2013
@Gnurou
Copy link
Member

Gnurou commented Feb 6, 2013

Merged, thanks!

@eichhirn
Copy link
Contributor Author

eichhirn commented Feb 6, 2013

Thank you, you could also close the issues that were solved:
#53, #47, #46, #41, #40, #39, #38, #37, #36

@Gnurou
Copy link
Member

Gnurou commented Feb 7, 2013

Feels good to close such a big bunch of issues. Thanks!

On Thu, Feb 7, 2013 at 5:19 AM, Jan Eichhorn notifications@github.comwrote:

Thank you, you could also close the issues that were solved:
#53 #53, #47#47,
#46 #46, #41#41,
#40 #40, #39#39,
#38 #38, #37#37,
#36 #36


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-13202862.

@ospalh ospalh mentioned this pull request Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants