-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #30, #38, #46, #47, +two Jouyou kanji, Stroke Numbers #50, Centering #39, Dots #37 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composed from 092cf and 982C. There was no template for 夾 in left position, the 从 element was created newly from duplicating the 人 element of 092cf. This might be wrong.
Affects kana only, the latin letters are from a different font. Letter 030ee ヮ additionally needed an y-shift. The kana punctuation marks did not match the font.
Merged, thanks! |
Feels good to close such a big bunch of issues. Thanks! On Thu, Feb 7, 2013 at 5:19 AM, Jan Eichhorn notifications@github.comwrote:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#47 02695-_1HzFst.svg error in name
#46 Displaced 751e, 9f4b, 5618
#38 05618-xxx displaced to the right
#40 63b4+848b Jinmei have codepoints of their own
Additions
Missing Jouyou kanji 9830 頰 ("cheek") and 5861 塡 ("fill up"), which was already present as 0586b-Jinmei.
.gitattributes file for line-ending normalization
Stroke Numbers (partial fix of #50)
Recovers the stroke numbers from the old SVG directory. I didn't check for any previous changes to the stroke numbers of these files, any such changes will have been overwritten.
Now there are only 5 files left with missing numbers:
Found not enough numbers to match #strokes 05300 0/4
Found not enough numbers to match #strokes 0583d 12/13
Found not enough numbers to match #strokes 05ac2 3/13
Found not enough numbers to match #strokes 0641c 3/13
Found not enough numbers to match #strokes 096e9 8/11
Centering Kana + Latin letters
#39 Latin letters, punctuation, kana should be centered (also #41)
Restore missing dots
I used Bezier curves instead of circle elements to prevent breakage of existing software. The fill attribute is used in some files, which was previously constant ("none").
#37 Missing dots