Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Re-enable e2e tests #1099

Closed
5 tasks done
kahboom opened this issue Jan 13, 2023 · 3 comments
Closed
5 tasks done

Re-enable e2e tests #1099

kahboom opened this issue Jan 13, 2023 · 3 comments
Assignees
Labels
chore Tests, CI/CD, general maintenance

Comments

@kahboom
Copy link
Contributor

kahboom commented Jan 13, 2023

Please describe the task that needs to be done

Now that the main issues with the code editor have been resolved, we should be able to add back e2e tests.

  • Create common happy paths
  • Update existing e2e tests
  • Add any missing e2e tests
  • Update relevant API keys where necessary
  • Ensure e2e tests are run on each PR

Tests should only be run against the main branch, not for forks. Relates to #1100.

@tplevko
Copy link
Contributor

tplevko commented Apr 13, 2023

Hi @kahboom I don't think there are any more steps to be taken from our side - no API keys updates needed AFAIK, so I think the PR checks can be enabled. I don't have permissions on the repo to do that, so could you have a look, whether this can be enabled?

@kahboom
Copy link
Contributor Author

kahboom commented Apr 21, 2023

@tplevko no worries I will take a look, thank you for all of your help with this!

@tplevko
Copy link
Contributor

tplevko commented May 19, 2023

@kahboom closing this as the e2e tests are already reenabled on PR's. Thanks for helping out with this.

@tplevko tplevko closed this as completed May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Tests, CI/CD, general maintenance
Projects
None yet
Development

No branches or pull requests

2 participants