This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Refactor e2e tests 4/5/6/8, fix autoScrolling issue #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1560 +/- ##
=======================================
Coverage 57.00% 57.00%
=======================================
Files 68 68
Lines 2056 2056
Branches 470 470
=======================================
Hits 1172 1172
Misses 840 840
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kahboom
reviewed
Mar 28, 2023
| @@ -35,6 +38,13 @@ Cypress.Commands.add('editorDeleteLine', (line, repeatCount) => { | |||
| ); | |||
| }); | |||
|
|
|||
| Cypress.Commands.add('editorClickUndoXTimes', (times) => { | |||
| times = times ?? 1; | |||
| Cypress._.times(times, () => { | |||
There was a problem hiding this comment.
I wonder if we are using lodash anywhere else (we probably are), though it would be good to try to remove it if possible. This would be a good alternative for this method in the future: https://youmightnotneed.com/lodash/#times
There was a problem hiding this comment.
Thanks, will fix it in the last refactor PR
kahboom
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
With that PR I want to update the new part of E2E tests (smaller + stable + with common commands)
Also fixed the strange issue in the cypress dashboard with the lowest (hidden!) frame resizing (issue was faced only in cypress, I did not found any related issue) ->
scrollBehavior: falseBefore:
After:
Related: