Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a VS Code setting for catalog url that Kaoto editor can read #1204

Closed
apupier opened this issue Jun 25, 2024 · 1 comment · Fixed by KaotoIO/vscode-kaoto#605
Closed
Assignees
Milestone

Comments

@apupier
Copy link
Member

apupier commented Jun 25, 2024

Note: How to test it in VS Code? local catalog committed?

@apupier
Copy link
Member Author

apupier commented Jun 26, 2024

Might require to change the setting from the Kaoto editor too, otherwise changing in the kaoto editor won't be kept for the next time an editor is opened.

apupier added a commit to apupier/kaoto-next that referenced this issue Jun 26, 2024
part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jun 26, 2024
Multiplying architecture

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jun 26, 2024
Multiplying architecture

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
lordrip pushed a commit that referenced this issue Jun 26, 2024
Multiplying architecture

part of #1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jun 27, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 1, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 1, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 1, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 2, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 3, 2024
url

it is setting it in the SettingsManager and do not pass it through all
components

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 4, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/kaoto-next that referenced this issue Jul 4, 2024
url

part of KaotoIO#1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Jul 4, 2024
url

part of #1204

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
lordrip added a commit to lordrip/kaoto that referenced this issue Jul 8, 2024
The lifecycle of a VSCode settings is like follows:

1. It starts with `null`
2. When the user updates it, it stores that value
3. When the user clears it, the value gets to be an empty string '""'

In case the `catalogUrl` is an empty string, we provide a fallback to
use the embedded catalog.

fix: KaotoIO#1109
relates: KaotoIO#1204
lordrip added a commit that referenced this issue Jul 8, 2024
The lifecycle of a VSCode settings is like follows:

1. It starts with `null`
2. When the user updates it, it stores that value
3. When the user clears it, the value gets to be an empty string '""'

In case the `catalogUrl` is an empty string, we provide a fallback to
use the embedded catalog.

fix: #1109
relates: #1204
@lordrip lordrip added this to the 2.1.0 milestone Jul 9, 2024
@lordrip lordrip self-assigned this Jul 9, 2024
@lordrip lordrip closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants