Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS inconsistency in Canvas Form Property type field #1473

Closed
shivamG640 opened this issue Sep 25, 2024 · 0 comments · Fixed by #1489
Closed

CSS inconsistency in Canvas Form Property type field #1473

shivamG640 opened this issue Sep 25, 2024 · 0 comments · Fixed by #1489
Assignees
@lordrip
Labels
bug Something isn't working
Milestone
2.3.0

Comments

@shivamG640
Copy link
Contributor

Describe the Bug

Following inconsistency need to be resolved:

  1. Property type field is not correctly fitting the form Panel:
    image

  2. Name property is not properly aligned:
    image

Steps to Reproduce the Bug or Issue

  1. In canvas, Create Kamelet configuration
  2. Click on kamelet configuration to check inconsistency in property type parameter.

Screenshots or Videos

No response

Platform

  • OS: [Linux
  • Browser: Chrome, Firefox
@shivamG640 shivamG640 added the bug Something isn't working label Sep 25, 2024
@lhein lhein moved this from New to Todo in Kanban Board Sep 25, 2024
@lhein lhein added this to the 2.3.0 milestone Sep 25, 2024
@lordrip lordrip self-assigned this Sep 30, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Sep 30, 2024
@lordrip
fix(PropertiesField): Reduce padding and start with expandable open
cef73df 
Currently, the `PropertiesField` component overflows from the containing
`Form`.

This commit:
* Reduces its padding
* Changes the containing `Td` so it can limit the overflow
* Extracts the `PropertiesFieldEmpty` state component
* Add a few missing tests

fix: KaotoIO#1473
@lordrip lordrip mentioned this issue Sep 30, 2024
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Sep 30, 2024
@lordrip
fix(PropertiesField): Reduce padding and start with expandable open
60ebaa1 
Currently, the `PropertiesField` component overflows from the containing
`Form`.

This commit:
* Reduces its padding
* Changes the containing `Td` so it can limit the overflow
* Extracts the `PropertiesFieldEmpty` state component
* Add a few missing tests

fix: KaotoIO#1473
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 1, 2024
@lordrip
fix(PropertiesField): Reduce padding and start with expandable open
3ed2df1 
Currently, the `PropertiesField` component overflows from the containing
`Form`.

This commit:
* Reduces its padding
* Changes the containing `Td` so it can limit the overflow
* Extracts the `PropertiesFieldEmpty` state component
* Add a few missing tests

fix: KaotoIO#1473
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 1, 2024
@lordrip
fix(PropertiesField): Reduce padding and start with expandable open
8b4e6d4 
Currently, the `PropertiesField` component overflows from the containing
`Form`.

This commit:
* Reduces its padding
* Changes the containing `Td` so it can limit the overflow
* Extracts the `PropertiesFieldEmpty` state component
* Add a few missing tests

fix: KaotoIO#1473
@lordrip lordrip closed this as completed in aa0c1b3 Oct 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
bug Something isn't working
Projects
Kanban Board
Archived in project
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

fix(CanvasForm): Improvements over the ParametersField component lordrip/kaoto
3 participants
@lhein @lordrip @shivamG640