Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas stuck after a parsing error #714

Closed
lordrip opened this issue Jan 24, 2024 · 0 comments · Fixed by #715
Closed

Canvas stuck after a parsing error #714

lordrip opened this issue Jan 24, 2024 · 0 comments · Fixed by #715
Assignees
@lordrip
Labels
bug Something isn't working canvas/visualization Canvas-related issues VS Code VS Code extension related issues
Milestone
2.0.0 TP1

Comments

@lordrip
Copy link
Member

lordrip commented Jan 24, 2024

Describe the Bug

If there's an error during a flow parsing, an error message is shown to the user to explain what happens and suggest checking the source code.

In the VSCode extension, the canvas doesn't refresh after an error, causing the editor to be stuck until the user closes the extension and reopens it again or switches to another tab.

Steps to Reproduce the Bug or Issue

  1. Open a Camel Route using the VSCode Kaoto extension
  2. At the same time, open the text editor and add a trailing - as a new step
  3. Notice how there's an error message that doesn't get away even after fixing the code

Screenshots or Videos

cannotShowEditor

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@lordrip lordrip added bug Something isn't working canvas/visualization Canvas-related issues VS Code VS Code extension related issues labels Jan 24, 2024
@lordrip lordrip moved this from New to In Review in Kanban Board Jan 24, 2024
@lordrip lordrip added this to the 2.0.0 TP1 milestone Jan 24, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 24, 2024
@lordrip
fix(canvas): Refersh canvas after error
650e703 
Currently, if there's an error during a flow parsing, an error message is shown to the user to explain what happens and suggest checking the source code. In the VSCode extension, the canvas doesn't refresh after an error, causing the editor to be stuck until the user closes the extension and reopens it again or switches to another tab.

This commit addresses this issue by assigning a `key` property to the error boundary component, so it gets refreshed after an entity update that happens only after editing the source code.

fix: KaotoIO#714
@lordrip lordrip mentioned this issue Jan 24, 2024
Merged
@lordrip lordrip self-assigned this Jan 24, 2024
@apupier apupier mentioned this issue Jan 24, 2024
Open
lordrip added a commit that referenced this issue Jan 24, 2024
@lordrip
fix(canvas): Refersh canvas after error
67bae3c 
Currently, if there's an error during a flow parsing, an error message is shown to the user to explain what happens and suggest checking the source code. In the VSCode extension, the canvas doesn't refresh after an error, causing the editor to be stuck until the user closes the extension and reopens it again or switches to another tab.

This commit addresses this issue by assigning a `key` property to the error boundary component, so it gets refreshed after an entity update that happens only after editing the source code.

fix: #714
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
bug Something isn't working canvas/visualization Canvas-related issues VS Code VS Code extension related issues
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

fix(canvas): Refresh canvas after error lordrip/kaoto
1 participant
@lordrip