fix: Added context menu to delete a container #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Good job @shivamG640, just a couple 💅:
-
We should try to do a test for this new interaction to make sure that we're able to remove the route or kamelet, it could be a basic test that right-clicks in the container and click on delete, then we check the delete method was called.
-
The next steps would be:
- Add a container for Pipes, so we can remove them like Kamelets
- Avoid creating new routes when deleting the existing one
For 1., if it's not too complex, we could include it in this very same PR whereas for 2., since it's optional, it would be better to have it in a separate PR.
|
Merging this PR now, to move forward with the repository rename. The upcoming tests will be added in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #974
The Canvas looks like this with the Context menu: