-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Settings): Add Settings Page #1201
Conversation
1e366a3
to
4566738
Compare
I think either we need to keep the index.json or use the non-raw url because there is no way in the UI to get the described url directly. i tis even giving a 400 Invalid request So either: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think either we need to keep the index.json or use the non-raw url because there is no way in the UI to get the described url directly. i tis even giving a 400 Invalid request
So either:
** https://raw.githubusercontent.com/lordrip/kaoto-catalog-test/main/index.json
** https://github.com/lordrip/kaoto-catalog-test/tree/main
for another iteration:
- check all camel catalog entries, it currently checks only the first one. The error on an entry catalog appears only when trying to load the catalog later. it might be anothe rbutton to call validate/Load test explicitely to avo dthat it take too much time.
4566738
to
5dc4d2c
Compare
Using the following URL: https://raw.githubusercontent.com/lordrip/kaoto-catalog-test/main/ works for me, as soon as you save it, the page gets refreshed, and if there's an error, it offers a mechanism to go back: |
it works to load it in Kaoto. |
ah, yes, I think is because loading the URL would be a folder, so nothing to deliver from the CDN perspective, but in Kaoto, we use this to build the final |
my point is that it makes things more complicated for end-users to stripe out the index.json than requiring it |
Ah, absolutely, got it, I'll adapt it to use the URL as an entry point directly then, so if someone wants to have Initially, I wasn't sure what was the best way to expose this information, so I kept the same approach. |
2dbca2d
to
5b32f91
Compare
I updated the PR to use the index.json file directly: https://raw.githubusercontent.com/lordrip/kaoto-catalog-test/main/index.json |
In the scope of selecting the Runtime in use, a settings page pointing to a catalog URL is needed. This commit adds a Settings component and a Settings provider. By default, it will store the settings to the browser's LocalStorage. The idea behind using a SettingsAdapter is to give the possibilit in the future to set the settings at VSCode level if needed. fix: KaotoIO#834
5b32f91
to
b6bd97f
Compare
Context
In the scope of selecting the Runtime in use, a settings page pointing to a catalog URL is needed.
This commit adds a Settings component and a Settings provider. By default, it will store the settings in the browser's LocalStorage.
The idea behind using a SettingsAdapter is to give the possibility to set the settings at the VSCode level if needed.
How to test
For setting a remote catalog you could use: https://raw.githubusercontent.com/lordrip/kaoto-catalog-test/main as URL
fix: #834