Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1100): Use '${body}' as default for Log's EIP message #1222

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix(1100): Use '${body}' as default for Log's EIP message #1222

merged 1 commit into from
Jul 8, 2024

Conversation

shivamG640
Copy link
Contributor

Fixes #1100

@shivamG640
Copy link
Contributor Author

Hi @lordrip
Is this text expected here in the message field?
image

@shivamG640 shivamG640 requested a review from lordrip July 1, 2024 10:00
@lordrip
Copy link
Member

lordrip commented Jul 2, 2024

Hi @lordrip Is this text expected here in the message field? image

Yes

@lordrip
Copy link
Member

lordrip commented Jul 2, 2024

@shivamG640 this needs to be handled on the UI side, in the default service.

@shivamG640
Copy link
Contributor Author

@lordrip Please review this!
Curious to know why we choose the service files to add this changes instead of the initial changes to the catalogs?

@lordrip
Copy link
Member

lordrip commented Jul 3, 2024

@lordrip Please review this! Curious to know why we choose the service files to add this changes instead of the initial changes to the catalogs?

Because we're not aiming to alter the catalog, we're rather providing or suggesting a useful default value.

lordrip
lordrip reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @shivamG640 , it looks good, please add a unit for it and we're good to go

@shivamG640 shivamG640 force-pushed the Fix_1100 branch 2 times, most recently from 991e295 to a220306 Compare July 4, 2024 20:09
@shivamG640 shivamG640 marked this pull request as ready for review July 4, 2024 20:28
@shivamG640 shivamG640 marked this pull request as draft July 4, 2024 20:29
@shivamG640 shivamG640 marked this pull request as ready for review July 4, 2024 20:49
@shivamG640 shivamG640 requested a review from lordrip July 4, 2024 20:49
@lordrip
Copy link
Member

lordrip commented Jul 8, 2024

Thanks for taking care of this @shivamG640 👍

@lordrip lordrip merged commit 50d1c43 into KaotoIO:main Jul 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ${body} as default for Log's EIP message
2 participants
@shivamG640 @lordrip