Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(viz): Remove unused populateLeafNodesIds method #1321

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Aug 16, 2024

Context

With the introduction of containers for branches (#1300), connecting leaf nodes with the previous elements are different.

The use of this method was removed here

fix: #368
fix: #1329

@lordrip lordrip changed the title chore(viz): Remove unused method chore(viz): Remove unused populateLeafNodesIds method Aug 18, 2024
@lordrip lordrip closed this Aug 18, 2024
@lordrip lordrip reopened this Aug 18, 2024
@lordrip
Copy link
Member Author

lordrip commented Aug 18, 2024

This method is under observation. It's possible that it's needed when we handle some EIPs differently.

@lhein lhein force-pushed the chore/remove-unused-method branch from 5ed66b2 to 0e6e298 Compare August 19, 2024 07:59
@lordrip lordrip merged commit 718a1b5 into KaotoIO:main Aug 19, 2024
9 checks passed
@lordrip lordrip deleted the chore/remove-unused-method branch August 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom visualization for EIPs Introduce containers in the canvas for branches
2 participants