Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(787): Display connector icon in catalog detail modal #1466

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(787): Display connector icon in catalog detail modal #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/ui/src/components/PropertiesModal/PropertiesModal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,17 @@
height: 60vh;
}
}

&__title-div {
display: flex;
}

&__title-image {
height: 50px;
width: 50px;
}

&__title {
padding: 10px;
}
}
24 changes: 19 additions & 5 deletions packages/ui/src/components/PropertiesModal/PropertiesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import { Modal, ModalBoxBody, Tab, Tabs } from '@patternfly/react-core';
import { FunctionComponent, useContext, useEffect, useMemo, useState } from 'react';
import { IPropertiesTab } from './PropertiesModal.models';
import { Modal, ModalBoxBody, Tab, Tabs, capitalize } from '@patternfly/react-core';
import { FunctionComponent, ReactElement, useContext, useEffect, useMemo, useState } from 'react';
import {
transformCamelComponentIntoTab,
transformCamelProcessorComponentIntoTab,
transformKameletComponentIntoTab,
} from '../../camel-utils/camel-to-tabs.adapter';
import { CatalogKind } from '../../models';
import { CatalogContext } from '../../providers';
import { NodeIconResolver, NodeIconType } from '../../utils';
import { ITile } from '../Catalog';
import { IPropertiesTab } from './PropertiesModal.models';
import './PropertiesModal.scss';
import { PropertiesTabs } from './PropertiesTabs';
import { EmptyTableState } from './Tables';
import { CatalogContext } from '../../providers';

interface IPropertiesModalProps {
tile: ITile;
Expand Down Expand Up @@ -50,6 +51,19 @@ export const PropertiesModal: FunctionComponent<IPropertiesModalProps> = (props)
setActiveTab(tabs[tabIndex as number]);
setActiveTabKey(tabIndex as number);
};
const nodeIconType = capitalize(props.tile.type === 'processor' ? 'EIP' : props.tile.type);
const iconName = nodeIconType === NodeIconType.Kamelet ? `kamelet:${props.tile.name}` : props.tile.name;

const title: ReactElement = (
<div className="properties-modal__title-div">
<img
className={'properties-modal__title-image'}
src={NodeIconResolver.getIcon(iconName, nodeIconType as NodeIconType)}
alt={`${props.tile.type} icon`}
/>
<h1 className="properties-modal__title">{props.tile.title}</h1>
</div>
);

const description = (
<div>
Expand All @@ -66,7 +80,7 @@ export const PropertiesModal: FunctionComponent<IPropertiesModalProps> = (props)
return (
<Modal
className="properties-modal"
title={props.tile.title}
title={title}
isOpen={props.isModalOpen}
onClose={props.onClose}
ouiaId="BasicModal"
Expand Down
8 changes: 4 additions & 4 deletions packages/ui/src/utils/node-icon-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,10 @@ import { CamelCatalogService } from '../models/visualization/flows/camel-catalog
import { EntityType } from '../models/camel/entities';

export const enum NodeIconType {
Component,
EIP,
Kamelet,
VisualEntity,
Component = 'Component',
EIP = 'EIP',
Kamelet = 'Kamelet',
VisualEntity = 'VisualEntity',
}

export class NodeIconResolver {
Expand Down