Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Put schema files into a Map to allow direct access with a schema… #151

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: Put schema files into a Map to allow direct access with a schema… #151

merged 1 commit into from
Sep 25, 2023

Conversation

igarashitm
Copy link
Contributor

… name

Following up #148

@igarashitm igarashitm requested a review from a team September 25, 2023 13:47
@igarashitm igarashitm marked this pull request as draft September 25, 2023 14:05
@igarashitm
Copy link
Contributor Author

Hold on, Camel K CRDs are also targeted for creating .d.ts but removed by mistake, restoring

@igarashitm igarashitm marked this pull request as ready for review September 25, 2023 14:21
@igarashitm
Copy link
Contributor Author

done

lordrip
lordrip approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lordrip lordrip merged commit 9cf8c4d into KaotoIO:main Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igarashitm @lordrip